Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to generate PDF with the screen CSS media type #312

Closed
astefanutti opened this issue Aug 16, 2017 · 1 comment
Closed

Add an option to generate PDF with the screen CSS media type #312

astefanutti opened this issue Aug 16, 2017 · 1 comment
Labels
feature P1

Comments

@astefanutti
Copy link

It seems the PDF generation activates the print CSS media type. While that makes sense in the majority of use cases, it would be very useful in some other use cases, like Decktape that exports HTML presentations for which it is preferable to retain the screen media type.
@astefanutti astefanutti mentioned this issue Aug 16, 2017
Closed
19 tasks
@ebidel ebidel added the pdf label Aug 16, 2017
@hbakhtiyor
Copy link

Chrome has some issue with generating pdf with screen media type,

here are my post & issue:
https://groups.google.com/a/chromium.org/forum/#!topic/headless-dev/-GEgfCiVTtE
https://bugs.chromium.org/p/chromium/issues/detail?id=749080

@rcarmo rcarmo mentioned this issue Aug 17, 2017
Closed
@pavelfeldman pavelfeldman removed the pdf label Aug 18, 2017
@aslushnikov aslushnikov mentioned this issue Aug 18, 2017
Merged
aslushnikov added a commit that referenced this issue Aug 18, 2017
@aslushnikov
Introduce page.emulateMedia method (#383)
6cc2741 
Emulating `screen` media would force `page.pdf()` to print with `screen`
media.

Fixes #312
@astefanutti astefanutti mentioned this issue Aug 25, 2017
Closed
@oliveiraethales oliveiraethales mentioned this issue Oct 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature P1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ebidel @astefanutti @aslushnikov @pavelfeldman @hbakhtiyor