Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emulated devices have old User Agents #3859

Closed
arjunyel opened this issue Jan 28, 2019 · 0 comments
Closed

Emulated devices have old User Agents #3859

arjunyel opened this issue Jan 28, 2019 · 0 comments

Comments

@arjunyel
Copy link

Steps to reproduce

Tell us about your environment:

What steps will reproduce the problem?

Please include code that reproduces the issue.

  1. Try to run an app that uses https://browser-update.org/
  2. Emulate device like page.emulate(devices['Pixel 2 XL']); and take a screenshot
  3. Screenshot displays warning from browser-update "Your web browser (Chrome 69) is out of date"

What is the expected result?
Expected result is the user agent is either the version of chromium or at least the current stable version available on mobile (e.g. Chrome 72 starting tomorrow);

What happens instead?
Instead all the user agents have chrome 69 hardcoded https://github.com/GoogleChrome/puppeteer/blob/master/DeviceDescriptors.js

aslushnikov added a commit to aslushnikov/puppeteer that referenced this issue Jan 29, 2019
aslushnikov added a commit that referenced this issue Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant