TS: waitForSelector should only resolve null when called with `hidden: true

[SimonSchick]

Steps to reproduce

Tell us about your environment:

• Puppeteer version: 1.12
• Platform / OS version: MacOS
• URLs (if applicable):
• Node.js version: 11.5

What steps will reproduce the problem?

Please include code that reproduces the issue.

const el = await page.waitForSelector(some-selector);

console.log(el.getProperty('somewhat'))

What is the expected result?

No error

What happens instead?

error TS2531: Object is possibly 'null'.

Ideally an overload should be added specifically checking if hidden: true, otherwise we have to add annoying null assertions where none are needed.

[SimonSchick]

Closing in favour of #3878

[jemunk]

What is the status of this? The year is 2024 and we still need to test if the result of waitForSelector returns null.
It could be so nice, that the hidden: true option, was refactored into its own method, like waitForHiddenSelector, and only let this one return null (or void).

[alamothe]

This can be resolved easily with overloading:

    waitForSelector<Selector extends string>(selector: Selector, options?: {
        visible?: boolean;
        hidden?: false;
        timeout?: number;
    }): Promise<ElementHandle<NodeFor<Selector>>>;
    waitForSelector<Selector extends string>(selector: Selector, options?: {
        visible?: boolean;
        hidden: true;
        timeout?: number;
    }): Promise<ElementHandle<NodeFor<Selector>> | null>;