New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
non matching contribution rules makes PR have errors #4559
Comments
tenuki
changed the title
non matching contribution ruls
non matching contribution rules makes PR have errors
Jun 10, 2019
aslushnikov
added a commit
to aslushnikov/puppeteer
that referenced
this issue
Jun 10, 2019
aslushnikov
added a commit
that referenced
this issue
Jun 10, 2019
This was referenced Feb 3, 2020
This was referenced Feb 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce
What steps will reproduce the problem?
contribution rules at: https://github.com/GoogleChrome/puppeteer/blob/master/CONTRIBUTING.md exemplify:
However after doing that and creating a pull request, commitlint is checking something different:
What is the expected result?
Not to give an error for what was not specified!
What happens instead?
Anyone discover new rules when it is too late.
The text was updated successfully, but these errors were encountered: