Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non matching contribution rules makes PR have errors #4559

Closed
tenuki opened this issue Jun 10, 2019 · 0 comments · Fixed by #4560
Closed

non matching contribution rules makes PR have errors #4559

tenuki opened this issue Jun 10, 2019 · 0 comments · Fixed by #4560

Comments

@tenuki
Copy link
Contributor

tenuki commented Jun 10, 2019

Steps to reproduce

What steps will reproduce the problem?

contribution rules at: https://github.com/GoogleChrome/puppeteer/blob/master/CONTRIBUTING.md exemplify:

fix(Page): fix page.pizza method

This patch fixes page.pizza so that it works with iframes.

Fixes #123, Fixes #234

BREAKING CHANGE: page.pizza now delivers pizza at home by default.
To deliver to a different location, use "deliver" option:
  `page.pizza({deliver: 'work'})`.

However after doing that and creating a pull request, commitlint is checking something different:


Pull request title

    fix(BrowserFetcher): fix httpRequest when using proxy against http HOST

Commitlint results

    ❌ scope must be lowerCase [scope-case]
    
Expected PR title format is: {type}({optional-scope}): {subject}

Full docs of commitlint rules

What is the expected result?

Not to give an error for what was not specified!

What happens instead?

Anyone discover new rules when it is too late.

@tenuki tenuki changed the title non matching contribution ruls non matching contribution rules makes PR have errors Jun 10, 2019
aslushnikov added a commit to aslushnikov/puppeteer that referenced this issue Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant