Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs/api.md to use async/await instead of Promise.prototype.then #5082

Closed
mathiasbynens opened this issue Oct 24, 2019 · 1 comment · Fixed by #5089
Closed

Update docs/api.md to use async/await instead of Promise.prototype.then #5082

mathiasbynens opened this issue Oct 24, 2019 · 1 comment · Fixed by #5089
Labels
good first issue

Comments

@mathiasbynens
Copy link
Member

Now that we've dropped support for Node.js v6, let's update the remaining code examples on https://github.com/GoogleChrome/puppeteer/blob/master/docs/api.md to use async/await. It makes them simpler and easier to follow.

Help welcome!
@randombenj randombenj mentioned this issue Oct 25, 2019
Merged
randombenj added a commit to randombenj/puppeteer that referenced this issue Oct 25, 2019
@randombenj
docs(api.md): use async/await instead of then
5c9813c 
fixes puppeteer#5082
mathiasbynens pushed a commit that referenced this issue Oct 26, 2019
@randombenj @mathiasbynens
docs(api.md): prefer async/await over Promise#then (#5089)
561c99d 
Fixes #5082.
@mathiasbynens
Copy link
Member Author

Thanks to @randombenj for contributing this change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(api.md): use async/await instead of then randombenj/puppeteer
1 participant
@mathiasbynens