Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please upgrade rimraf version in package.json to fix the exception by fixWinEPERM #5425

Closed
dsheiko opened this issue Feb 17, 2020 · 1 comment · Fixed by #5431
Closed

Please upgrade rimraf version in package.json to fix the exception by fixWinEPERM #5425

dsheiko opened this issue Feb 17, 2020 · 1 comment · Fixed by #5431

Comments

@dsheiko
Copy link
Contributor

dsheiko commented Feb 17, 2020

Currently (Puppeteer 2.1.1) on Windows 10 throws

AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:                                      
  assert(er instanceof Error)
  at fixWinEPERM (.\node_modules\rimraf\rimraf.js:175:5)

pretty much the same as described here isaacs/rimraf#155

My guess, it happens when puppeteer removes tmp folder on this.proc exit event:
https://github.com/puppeteer/puppeteer/blob/master/lib/Launcher.js#L99

However, if one updates the rimraf to the latest version, everything works fine.
E.g.

cd node_modules/puppeteer
npm i rimraf@latest

P.S. I'm running puppeteer with the following options:

await puppeteer.launch(
    "product": "firefox",
    "headless": false,
    "devtools": false,
    "ignoreHTTPSErrors": false,
    "args": [
      "--wait-for-browser"
    ],
    "executablePath": "C:\\Program Files (x86)\\Nightly\\firefox.exe"
  });
@aslushnikov
Copy link
Contributor

For the record: this was investigated in isaacs/rimraf#208 and fixed with isaacs/rimraf@aa50e02

aslushnikov added a commit to aslushnikov/puppeteer that referenced this issue Feb 19, 2020
`rimraf` version 3.0.2 doesn't throw any more when used
in Jest environment.

Fixes puppeteer#5425
hanselfmu pushed a commit that referenced this issue Mar 12, 2020
`rimraf` version 3.0.2 doesn't throw any more when used
in Jest environment.

Fixes #5425
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants