Spawning browser with detached = false

[KishanBagaria]

Is it possible to always launch the child process with detached = false?

puppeteer/src/Launcher.js

Lines 77 to 88 in 8509f46

	this.proc = childProcess.spawn(
	this._executablePath,
	this._processArguments,
	{
	// On non-windows platforms, `detached: true` makes child process a leader of a new
	// process group, making it possible to kill child process tree with `.kill(-pid)` command.
	// @see https://nodejs.org/api/child_process.html#child_process_options_detached
	detached: process.platform !== 'win32',
	env,
	stdio
	}
	);

In some instances, puppeteer browsers linger even after the parent process is closed/killed.

This can be reproduced by using a worker thread.

p1.js:

const { Worker, isMainThread } = require('worker_threads')

if (isMainThread) {
  new Worker(__filename)
  console.log('main thread')
} else {
  require('./p2')
}

p2.js:

const puppeteer = require('puppeteer')

console.log('worker thread')

puppeteer.launch({
  headless: false,
  executablePath: '/Applications/Google Chrome.app/Contents/MacOS/Google Chrome',
})

Run node p1, once the browser opens, hit Ctrl+C, you'll notice the node process has exited but the browser still lingers.

I'm working around this by sending a cleanup signal from the main thread to the worker thread and manually closing the puppeteer instance in the worker thread. This isn't ideal and has been error prone.

This might help solve #1825