Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The documentation does not explain what a 'Target' is #5880

Closed
jribbens opened this issue May 18, 2020 · 6 comments
Closed

The documentation does not explain what a 'Target' is #5880

jribbens opened this issue May 18, 2020 · 6 comments

Comments

@jribbens
Copy link

The Puppeteer API documentation lists a type called a 'Target', but does not explain what it is and how it relates to BrowserContexts/Pages/Frames/etc. In particular it is missing from the diagram in the Overview, and there is no explanation of its lifecycle - e.g. you can use page.target() to get a target related to a page, but how long does it live for? If you page.goto() another URL, do you need to fetch a new Target? etc

@stale
Copy link

stale bot commented Jun 26, 2022

We're marking this issue as unconfirmed because it has not had recent activity and we weren't able to confirm it yet. It will be closed if no further activity occurs within the next 30 days.

@stale stale bot added the unconfirmed label Jun 26, 2022
@jribbens
Copy link
Author

Not stale

@stale stale bot removed the unconfirmed label Jun 26, 2022
@stale
Copy link

stale bot commented Aug 30, 2022

We're marking this issue as unconfirmed because it has not had recent activity and we weren't able to confirm it yet. It will be closed if no further activity occurs within the next 30 days.

@stale stale bot added the unconfirmed label Aug 30, 2022
@jribbens
Copy link
Author

jribbens commented Sep 2, 2022

Not stale

@OrKoN
Copy link
Collaborator

OrKoN commented Sep 5, 2022

Target is a CDP-specific concept that I think should not be directly exposed to the end-users but it unfortunately was. There is some documentation here https://github.com/aslushnikov/getting-started-with-cdp/blob/master/README.md#targets--sessions but, generally, I think we should try to deprecate the target API instead of documenting it better.

@jribbens
Copy link
Author

jribbens commented Sep 5, 2022

Presumably there would still be some way of getting a CDP connection?

OrKoN added a commit that referenced this issue Dec 9, 2022
OrKoN added a commit that referenced this issue Dec 9, 2022
OrKoN added a commit that referenced this issue Dec 9, 2022
@OrKoN OrKoN closed this as completed Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants