Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce page.$eval and page.$$eval #625

Closed
aslushnikov opened this issue Aug 30, 2017 · 0 comments
Closed

Introduce page.$eval and page.$$eval #625

aslushnikov opened this issue Aug 30, 2017 · 0 comments
Assignees
@aslushnikov
Labels
feature

Comments

@aslushnikov
Copy link
Contributor

@paulirish suggested to introduce page.$eval and page.$$eval that will reduce the need for a lot one-line methods.

E.g. elementHandle.attribute would be replaced with a one-liner:

let idAttribute = await page.$eval('div', div => div.id);

So the plan is:

  • introduce frame.$eval / frame.$$eval / page.$eval / page.$$eval
  • drop the elementHandle.attribute
@aslushnikov aslushnikov mentioned this issue Aug 31, 2017
Closed
@paulirish paulirish mentioned this issue Aug 31, 2017
Closed
@aslushnikov aslushnikov self-assigned this Aug 31, 2017
aslushnikov added a commit to aslushnikov/puppeteer that referenced this issue Aug 31, 2017
@aslushnikov
Implement page.$eval
db495c1 
This patch:
- implements page.$eval and frame.$eval
- drops elementHandle.attribute() method in favor of the page.$eval

References puppeteer#625
@aslushnikov aslushnikov mentioned this issue Aug 31, 2017
Merged
aslushnikov added a commit that referenced this issue Aug 31, 2017
@aslushnikov
Implement page.$eval (#638)
62ececb 
This patch:
- implements page.$eval and frame.$eval
- drops elementHandle.attribute() method in favor of the page.$eval

References #625
aslushnikov added a commit to aslushnikov/puppeteer that referenced this issue Oct 11, 2017
@aslushnikov
feat(Page): introduce Page.$$eval method
1e2dff8 
This patch adds a Page.$$eval method that runs document.querySelectorAll
and passes resulting array to the page function.

Fixes puppeteer#625.
@aslushnikov aslushnikov mentioned this issue Oct 11, 2017
Merged
aslushnikov added a commit that referenced this issue Oct 11, 2017
@aslushnikov
feat(Page): introduce Page.$$eval method (#1006)
7a8aa73 
This patch adds a `Page.$$eval` method that runs `document.querySelectorAll`
and passes resulting array to the page function.

Fixes #625.
ithinkihaveacat pushed a commit to ithinkihaveacat/puppeteer that referenced this issue Oct 31, 2017
@aslushnikov @ithinkihaveacat
feat(Page): introduce Page.$$eval method (puppeteer#1006)
8e04e03 
This patch adds a `Page.$$eval` method that runs `document.querySelectorAll`
and passes resulting array to the page function.

Fixes puppeteer#625.
@snyk-bot snyk-bot mentioned this issue May 4, 2022
Open
@snyk-bot snyk-bot mentioned this issue May 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aslushnikov aslushnikov

Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aslushnikov