Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint jsdoc types #65

Closed
aslushnikov opened this issue Jul 8, 2017 · 3 comments
Closed

lint jsdoc types #65

aslushnikov opened this issue Jul 8, 2017 · 3 comments
Labels
health

Comments

@aslushnikov
Copy link
Contributor

We should lint jsdoc types.

I spent some time trying to make closure compiler work with node.js, but it didn't work due to issues with node module requires.
@JoelEinbinder JoelEinbinder mentioned this issue Jul 26, 2017
Merged
aslushnikov pushed a commit that referenced this issue Jul 26, 2017
@JoelEinbinder @aslushnikov
Small fixes to jsdoc (#140)
9363a15 
References #65.
@JoelEinbinder
Copy link
Collaborator

I tried using typescript to do type checking. I had some success after removing all of our requires and module exports, and concatenating everything into one big file. There were a lot of errors because our WebSocket is different from browser's WebSocket, and typescript gets confused by frame.evaluate because of the context switch and the way arguments are passed in.

@JoelEinbinder JoelEinbinder mentioned this issue Aug 8, 2017
Closed
@sukrosono
Copy link
Contributor

Did the code base will use typescript after pull number 219 finished ? 😨

@JoelEinbinder JoelEinbinder mentioned this issue Oct 10, 2017
Merged
aslushnikov pushed a commit that referenced this issue Oct 10, 2017
@JoelEinbinder @aslushnikov
chore: Use Typescript to lint JSDoc annotations (#986)
e59172d 
This patch starts using typescript to lint JSDoc annotations.

Note: this uses typescript's bleeding edge. We should migrate to stable once
it has all the necessary bugfixes.

References #65.
@aslushnikov
Copy link
Contributor Author

Did the code base will use typescript after pull number 219 finished ? 😨

@brutalcrozt no, we'll continue using JS with jsdoc annotations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
health
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@aslushnikov @pavelfeldman @sukrosono @JoelEinbinder