Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate CI to GitHub Actions #6726

Closed
mathiasbynens opened this issue Jan 5, 2021 · 3 comments
Closed

Migrate CI to GitHub Actions #6726

mathiasbynens opened this issue Jan 5, 2021 · 3 comments

Comments

@mathiasbynens
Copy link
Member

mathiasbynens commented Jan 5, 2021 •
edited

Travis has effectively rendered their free plan useless, so we'll have to migrate to something else. Builds are currently stalling, and PRs cannot be merged without admin overrides (and without knowing whether the patch is safe to land!). Even before Travis made this change, builds have been unreliable.

GitHub Actions seems like a decent alternative.

For reference, here's our current Travis config: https://github.com/puppeteer/puppeteer/blob/cac540be3ab8799a1d77b0951b16bc22ea1c2adb/.travis.yml
@mathiasbynens mathiasbynens mentioned this issue Jan 5, 2021
Merged
@mathiasbynens
Copy link
Member Author

mathiasbynens commented Jan 12, 2021 •
edited

#6739 landed the main CI checks for Linux. What's left to do is to set things up so these can run on Windows and macOS as well.

@mathiasbynens mathiasbynens mentioned this issue Jan 26, 2021
Merged
mathiasbynens added a commit that referenced this issue Jan 26, 2021
@mathiasbynens
chore(ci): use GitHub Actions to run unit tests on Windows and macOS
9903793 
Similar to our earlier Travis CI setup, we continue to run exhaustive checks on Linux, while also verifying the build + unit tests still work on other platforms.

Issue: #6726
mathiasbynens added a commit that referenced this issue Jan 27, 2021
@mathiasbynens
chore(ci): use GitHub Actions to run unit tests on Windows and macOS (#…
c49d109 
…6782)

Similar to our earlier Travis CI setup, we continue to run exhaustive checks on Linux, while also verifying the build + unit tests still work on other platforms.

Issue: #6726
mathiasbynens added a commit that referenced this issue Feb 2, 2021
@mathiasbynens
chore: drop Travis CI config
fa251da 
Now that we’ve migrated to GitHub Actions and everything seems to work correctly, we can remove Travis CI without losing confidence.

Issue: #6726
@mathiasbynens mathiasbynens mentioned this issue Feb 2, 2021
Merged
mathiasbynens added a commit that referenced this issue Feb 2, 2021
@mathiasbynens
chore: drop Travis CI config (#6799)
f7f122d 
Now that we’ve migrated to GitHub Actions and everything seems to work correctly, we can remove Travis CI without losing confidence.

Issue: #6726
@mathiasbynens
Copy link
Member Author

Now that Travis can no longer hang our CI status checks, we can enable auto-merge on pull requests 🥳 I’ve gone ahead and done this. PRs can now be merged automatically when all required reviews are met and status checks are passed. No more waiting on CI before manually merging!

@mathiasbynens
Copy link
Member Author

I’ve revoked Travis CI’s access from both this repository and the puppeteer GitHub org. I manually deleted its webhooks as well.

@theDavidBarton theDavidBarton mentioned this issue Feb 6, 2021
Merged
mathiasbynens pushed a commit that referenced this issue Feb 8, 2021
@theDavidBarton
chore: clean up remaining Travis references (#6826)
b047023 
Issue: #6726
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mathiasbynens