New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: console level #744
Labels
Comments
michaelfward
added a commit
to michaelfward/puppeteer
that referenced
this issue
Sep 18, 2017
michaelfward
added a commit
to michaelfward/puppeteer
that referenced
this issue
Sep 18, 2017
@ebidel - I didn't know if creating a Let me know what you recommend and I'll submit a PR! |
@michaelfward I like page.console.on('log', console.log);
page.console.on('warn', console.warn);
page.console.on('debug', console.debug);
page.console.on('pageerror', console.error); |
aslushnikov
added a commit
that referenced
this issue
Sep 29, 2017
This patch introduces ConsoleMessage type and starts dispatching it for the 'console' event. BREAKING CHANGE: this breaks the api of the 'console' event. Fixes #744.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Page offers a console event but it is not possible to know the level of the message (log, error...).
Would it be possible to implement a way to know the level? I don't know what would be the cleanest way, either one more event per level:
or a new type of event:
Basically here: https://github.com/GoogleChrome/puppeteer/blob/master/lib/Page.js#L308 the event type is totally ignored
The text was updated successfully, but these errors were encountered: