-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: aria/ queries don't support single-quote delimiters for role names #7721
Comments
Note that, in the log output, I'm using a different selector and API function than the ones suggested in the repro steps. You can see in the source code for |
I think it was a conscious decision to limit the API to just double quote delimiters to simplify the selector syntax a bit. |
I think it's more an issue that they look similar to attribute selectors and a lot of people use I could probably submit a PR today for this, since it's a pretty quick and easy fix. |
This updates the regular expression used to parse aria attribute selectors so that single quotes may be used as an alternative to double quotes, e.g. `aria/Single button[role='button']`. Issues: puppeteer#7721
Closing this issue since the PR has now been merged. |
Bug description
Steps to reproduce the problem:
role="region"
attribute setpage.$()
with the following query:aria/[role='region']
null
Puppeteer version
v10.4.0
Node.js version
v16.12.0
npm version
v8.1.0
What operating system are you seeing the problem on?
Linux, macOS, Windows
Relevant log output
The text was updated successfully, but these errors were encountered: