Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard emulation is not perfect #777

Closed
2 tasks done
aslushnikov opened this issue Sep 14, 2017 · 2 comments
Closed
2 tasks done

Keyboard emulation is not perfect #777

aslushnikov opened this issue Sep 14, 2017 · 2 comments
Assignees
@JoelEinbinder
Labels
feature P1

Comments

@aslushnikov
Copy link
Contributor

aslushnikov commented Sep 14, 2017 •
edited

Keyboard emulation is not perfect
@JoelEinbinder JoelEinbinder mentioned this issue Oct 11, 2017
Merged
aslushnikov pushed a commit that referenced this issue Oct 12, 2017
@JoelEinbinder @aslushnikov
fix(input) Send .code with keyboard events (#1015)
c893bf3 
This patch starts sending proper `.code` field with emulated keyboard events.

References #777.
@aslushnikov
Copy link
Contributor Author

For the record: event.location is merged upstream as crrev.com/509990

aslushnikov added a commit to aslushnikov/puppeteer that referenced this issue Oct 20, 2017
@aslushnikov
feat(Chromium): roll Chromium to r510141
a4273cb 
This roll includes the following important revisions:
- https://crrev.com/509990 - DevTools: Allow location to be specified in
  Input.dispatchKeyEvent
- https://crrev.com/509486 - DevTools: fix extra HTTP headers not sent
on browser navigation request

References puppeteer#877, references puppeteer#777
@aslushnikov aslushnikov mentioned this issue Oct 20, 2017
Merged
aslushnikov added a commit that referenced this issue Oct 20, 2017
@aslushnikov
feat(Chromium): roll Chromium to r510141 (#1101)
ace239c 
This roll includes the following important revisions:
- https://crrev.com/509990 - DevTools: Allow location to be specified in
  Input.dispatchKeyEvent
- https://crrev.com/509486 - DevTools: fix extra HTTP headers not sent
on browser navigation request

References #877, references #777
scheib pushed a commit to scheib/chromium that referenced this issue Oct 20, 2017
@JoelEinbinder
DevTools: Allow location to be specified in Input.dispatchKeyEvent
d5b1a0e 
Puppeteer issue: puppeteer/puppeteer#777

Bug: none
Change-Id: Ib823af902263c7993978498174348fff28b47e1e
Reviewed-on: https://chromium-review.googlesource.com/714280
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509990}
@JoelEinbinder JoelEinbinder mentioned this issue Oct 23, 2017
Merged
JoelEinbinder added a commit that referenced this issue Oct 23, 2017
@JoelEinbinder
feat(keyboard): Accept codes (#1116)
126ab7b 
BREAKING CHANGE:

This patch lets key names be code in addition to key. When specifying a code, the proper text is generated assuming a standard US keyboard layout. e.g Digit5 -> "5" or "%" depending on Shift.

* location is now specified. #777

* Using unknown key names now throws an error. #723

* Typing newlines now correctly presses enter. #681
@aslushnikov
Copy link
Contributor Author

This is fixed now.

ithinkihaveacat pushed a commit to ithinkihaveacat/puppeteer that referenced this issue Oct 31, 2017
@JoelEinbinder @ithinkihaveacat
fix(input) Send .code with keyboard events (puppeteer#1015)
6fce388 
This patch starts sending proper `.code` field with emulated keyboard events.

References puppeteer#777.
ithinkihaveacat pushed a commit to ithinkihaveacat/puppeteer that referenced this issue Oct 31, 2017
@aslushnikov @ithinkihaveacat
feat(Chromium): roll Chromium to r510141 (puppeteer#1101)
6e46411 
This roll includes the following important revisions:
- https://crrev.com/509990 - DevTools: Allow location to be specified in
  Input.dispatchKeyEvent
- https://crrev.com/509486 - DevTools: fix extra HTTP headers not sent
on browser navigation request

References puppeteer#877, references puppeteer#777
ithinkihaveacat pushed a commit to ithinkihaveacat/puppeteer that referenced this issue Oct 31, 2017
@JoelEinbinder @ithinkihaveacat
feat(keyboard): Accept codes (puppeteer#1116)
24882cd 
BREAKING CHANGE:

This patch lets key names be code in addition to key. When specifying a code, the proper text is generated assuming a standard US keyboard layout. e.g Digit5 -> "5" or "%" depending on Shift.

* location is now specified. puppeteer#777

* Using unknown key names now throws an error. puppeteer#723

* Typing newlines now correctly presses enter. puppeteer#681
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoelEinbinder JoelEinbinder

Labels
feature P1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aslushnikov @JoelEinbinder