Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add addStyleTag(url) API #892

Closed
SamVerschueren opened this issue Sep 27, 2017 · 3 comments
Closed

Add addStyleTag(url) API #892

SamVerschueren opened this issue Sep 27, 2017 · 3 comments
Labels
feature

Comments

@SamVerschueren
Copy link
Contributor

Puppeteer has a addScriptTag(url) method, it would be nice to have a addStyleTag(url) as well to easily add external styles.

// @kevva @sindresorhus
@SamVerschueren SamVerschueren mentioned this issue Sep 27, 2017
Open
6 tasks
@aslushnikov
Copy link
Contributor

Sounds reasonable. This is easy to implement similarly to addScriptTag implemention.

I'd appreciate if someone sends a PR for this (with a test and documentation).

@SamVerschueren
Copy link
Contributor Author

Thanks for pointing to that location. Would like to take this one :).

SamVerschueren added a commit to SamVerschueren/puppeteer that referenced this issue Oct 3, 2017
@SamVerschueren
feat(Frame): Add addStyleTag API to frame - fixes puppeteer#892
0ebf6f2
@SamVerschueren SamVerschueren mentioned this issue Oct 3, 2017
Merged
@SamVerschueren
Copy link
Contributor Author

Added a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aslushnikov @SamVerschueren