New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: use ~/.cache/puppeteer
for browser downloads
#9095
Conversation
94f64e7
to
df29159
Compare
As of puppeteer@19, browser downloads go to ~/.cache/puppeteer and not into .local_chromium (see puppeteer/puppeteer#9095)
* bump deps * Update bundle script As of puppeteer@19, browser downloads go to ~/.cache/puppeteer and not into .local_chromium (see puppeteer/puppeteer#9095)
This is needed due to the breaking change in version 19 puppeteer/puppeteer#9095
This is needed due to the breaking change in version 19 puppeteer/puppeteer#9095
We override `PUPPETEER_CACHE_DIR` to a directory inside the workspace so that this can be persisted. As access to parent directories is not allowed in circle ci when using persist_to_workspace. This is needed due to the breaking change in version 19 puppeteer/puppeteer#9095
We override `PUPPETEER_CACHE_DIR` to a directory inside the workspace so that this can be persisted. As access to parent directories is not allowed in circle ci when using persist_to_workspace. This is needed due to the breaking change in version 19 puppeteer/puppeteer#9095
We override `PUPPETEER_CACHE_DIR` to a directory inside the workspace so that this can be persisted. As access to parent directories is not allowed in circle ci when using persist_to_workspace. This is needed due to the breaking change in version 19 puppeteer/puppeteer#9095
We override `PUPPETEER_CACHE_DIR` to a directory inside the workspace so that this can be persisted. As access to parent directories is not allowed in circle ci when using persist_to_workspace. This is needed due to the breaking change in version 19 puppeteer/puppeteer#9095
We override `PUPPETEER_CACHE_DIR` to a directory inside the workspace so that this can be persisted. As access to parent directories is not allowed in circle ci when using persist_to_workspace. This is needed due to the breaking change in version 19 puppeteer/puppeteer#9095
This is needed due to the breaking change in version 19 puppeteer/puppeteer#9095
This is needed due to the breaking change in version 19 puppeteer/puppeteer#9095
This is needed due to the breaking change in version 19 puppeteer/puppeteer#9095
After this upgrade, Ubuntu shows some errors when running. This seems to be a problem with the chrome path. The error that is eventually reported after relying on the installation is difficult to solve. Note that this is the case with Ubuntu.
|
How do I restore the previous behaviour on new versions? When Puppeteer is installed globally by root, this change causes Chrome to be inaccessible for regular users. |
This PR moves browser downloads into
~/.cache/puppeteer
to make use of global caching. This allows for better, cross-project installation of browsers and simplifies the location of browsers.Previously, Puppeteer download Chromium to
.local_chromium
wherever yourpuppeteer-core
was installed.Now, Puppeteer will download Chromium into
$PUPPETEER_CACHE_DIR/chrome
(wherePUPPETEER_CACHE_DIR
defaults to~/.cache/puppeteer
).Synonymous statements can be said for Firefox.