Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Skip Chromium download removed from install.js #9158

Closed
denny99 opened this issue Oct 24, 2022 · 0 comments · Fixed by #9160
Closed

[Bug]: Skip Chromium download removed from install.js #9158

denny99 opened this issue Oct 24, 2022 · 0 comments · Fixed by #9160
Assignees
Labels

Comments

@denny99
Copy link

denny99 commented Oct 24, 2022

Bug description

https://github.com/puppeteer/puppeteer/blob/v19.0.0/packages/puppeteer/install.js
https://github.com/puppeteer/puppeteer/blob/v19.1.0/packages/puppeteer/install.js

With version 19.1.0 the Code Snippets for checking the skip download variables has been removed completely.
Instead you moved this code to the configuration and second install file here:

https://github.com/puppeteer/puppeteer/blob/v19.1.1/packages/puppeteer/src/node/install.ts

The skip download is logged and then. Just continued. The return is missing here and you cannot prevent the installation of the browser...

Puppeteer version

19.1.1

Node.js version

18.x

npm version

8.x

What operating system are you seeing the problem on?

macOS

Relevant log output

> [npm-dependencies 1/1] RUN export PUPPETEER_SKIP_DOWNLOAD=true; npm install --only=production nestjs-redoc @nestjs/axios pug puppeteer-cluster bull sharp moment:
#0 23.47 npm ERR! code 1
#0 23.47 npm ERR! path /usr/src/nest-app/node_modules/puppeteer
#0 23.47 npm ERR! command failed
#0 23.47 npm ERR! command sh -c -- node install.js
#0 23.47 npm ERR! **INFO** Skipping browser download as instructed.
#0 23.47 npm ERR! The chromium binary is not available for arm64.
#0 23.47 npm ERR! If you are on Ubuntu, you can install with: 
#0 23.47 npm ERR! 
#0 23.47 npm ERR!  sudo apt install chromium
#0 23.47 npm ERR! 
#0 23.47 npm ERR! 
#0 23.47 npm ERR!  sudo apt install chromium-browser
#0 23.47 npm ERR! 
#0 23.47 npm ERR! ERROR: Failed to set up Chromium r1045629! Set "PUPPETEER_SKIP_DOWNLOAD" env variable to skip download.
#0 23.47 npm ERR! Error
#0 23.47 npm ERR!     at handleArm64 (/usr/src/nest-app/node_modules/puppeteer-core/lib/cjs/puppeteer/node/BrowserFetcher.js:137:11)
#0 23.47 npm ERR!     at BrowserFetcher.download (/usr/src/nest-app/node_modules/puppeteer-core/lib/cjs/puppeteer/node/BrowserFetcher.js:284:13)
#0 23.47 npm ERR!     at async downloadBrowser (/usr/src/nest-app/node_modules/puppeteer/lib/cjs/puppeteer/node/install.js:65:5)
#0 23.47 
#0 23.47 npm ERR! A complete log of this run can be found in:
#0 23.47 npm ERR!     /root/.npm/_logs/2022-10-24T15_08_53_000Z-debug-0.log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants