Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: browsers package: "install chromium" should have the same outcome as "install chrome" #9759

Closed
thiagowfx opened this issue Mar 1, 2023 · 0 comments · Fixed by #9760
Assignees
Labels

Comments

@thiagowfx
Copy link
Contributor

Feature description

$ npx @puppeteer/browsers install chromium@latest
browsers install <browser>

Download and install the specified browser

Positionals:
  browser  The browser version                               [string] [required]

Options:
  --version   Show version number                                      [boolean]
  --help      Show help                                                [boolean]
  --platform  Platform that the binary needs to be compatible with.
       [string] [choices: "linux", "mac", "mac_arm", "win32", "win64"] [default:
                                                      Auto-detected by default.]
  --path      Path where the browsers will be downloaded to and installed from
                             [string] [default: "/private/tmp/tperrotta-yCeS9U"]

TypeError: browsers_js_1.downloadUrls[browser] is not a function
    at getDownloadUrl (/Users/tperrotta/.npm/_npx/c99440fc2d0a3f00/node_modules/@puppeteer/browsers/lib/cjs/fetch.js:87:55)
    at fetch (/Users/tperrotta/.npm/_npx/c99440fc2d0a3f00/node_modules/@puppeteer/browsers/lib/cjs/fetch.js:40:17)
    at Object.handler (/Users/tperrotta/.npm/_npx/c99440fc2d0a3f00/node_modules/@puppeteer/browsers/lib/cjs/CLI.js:80:40)

Observed: install chromium does not work
Expected: install chromium should work, and have the same effect as install chrome.

Why? install chrome actually installs Chromium under the hood. Therefore one would expect that install chromium would also do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants