feat(Page): introduce Page.queryObjects #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch introduces Page.queryObjects and ExecutionContext.queryObjects methods to query JavaScript heap for objects with a certain prototype. Fixes puppeteer#304.
test/test.js
Outdated
| await page.evaluate(() => window.map = new Map()); | ||
| const prototypeHandle = await page.evaluateHandle(() => Map.prototype); | ||
| const objectsHandle = await page.queryObjects(prototypeHandle); | ||
| const count = await page.evaluate(objects => objects.length, objectsHandle); |
There was a problem hiding this comment.
To make me feel safer, can we actually check that the object here is the map and is usable.
|
This is really exciting. It feels a bit clumsy to use, but maybe that is ok. I was hoping for something like |
Disposing an array of JSHandles is not very nice and talkative from protocol's point of view: await Promise.all(handles.map(handle => handle.dispose()));Most of the time you'll be satisfied with inspecting the objects with const objectPrototype = await page.evaluateHandle(() => Object.prototype);
const objectsHandle = await page.queryObjects(objectPrototype);
const count = await page.evaluate(objects => objects.length, objectsHandle); |
ithinkihaveacat
pushed a commit
to ithinkihaveacat/puppeteer
that referenced
this pull request
Oct 31, 2017
This patch introduces `Page.queryObjects` and `ExecutionContext.queryObjects` methods to query JavaScript heap for objects with a certain prototype. Fixes puppeteer#304.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces
Page.queryObjectsandExecutionContext.queryObjectsmethods to query JavaScript heapfor objects with a certain prototype.
Fixes #304.