fix: add Host header when used with http_proxy #10080
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: add Host header when used with http_proxy
What kind of change does this PR introduce?
a bugfix
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
no
Other information
manual
http.get()
differs from use aagent = HttpProxyAgent()
(imported from http-proxy-agent package) instance, forHost
header.say proxy for
https://httpbin.org/headers
https.get('https://httpbin.org/headers', { agent: HttpProxyAgent('http://127.0.0.1:54321') })
will haveHost: httpbin.org
sent to127.0.0.1:54321
https.get
without Host set will use proxy's host127.0.0.1:54321
which breaks my current proxy server.I found some evidence indicates it's client's job to make it right.
AND why https-proxy-agent but not http-proxy-agent?