-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support chrome-headless-shell #10739
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it needs a |
OrKoN
approved these changes
Aug 16, 2023
mathiasbynens
force-pushed
the
chrome-headless-shell
branch
from
August 16, 2023 08:21
72e719a
to
ba705d5
Compare
|
OrKoN
force-pushed
the
chrome-headless-shell
branch
from
August 16, 2023 08:22
ba705d5
to
23f069c
Compare
also, |
mathiasbynens
force-pushed
the
chrome-headless-shell
branch
from
August 16, 2023 08:35
23f069c
to
c53a5ff
Compare
Docs pushed! |
mathiasbynens
force-pushed
the
chrome-headless-shell
branch
from
August 16, 2023 08:37
c53a5ff
to
c3b77c1
Compare
@mathiasbynens I have overlooked missing tests, let's add a test for the chrome-headless-shell browser-data and perhaps one test making sure it's actually installable? |
also, it looks like the Firefox version has gone outdated so we need to bump it in the test files. |
mathiasbynens
force-pushed
the
chrome-headless-shell
branch
from
August 16, 2023 11:22
c3b77c1
to
74285e9
Compare
OrKoN
approved these changes
Aug 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #10736