Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support chrome-headless-shell #10739

Merged
merged 1 commit into from
Aug 16, 2023
Merged

feat: support chrome-headless-shell #10739

merged 1 commit into from
Aug 16, 2023

Conversation

mathiasbynens
Copy link
Member

@mathiasbynens mathiasbynens commented Aug 16, 2023

Issue: #10736

@OrKoN
Copy link
Collaborator

OrKoN commented Aug 16, 2023

I think it needs a npm run format

@mathiasbynens
Copy link
Member Author

npm run format done!

@OrKoN OrKoN enabled auto-merge (squash) August 16, 2023 08:22
@OrKoN
Copy link
Collaborator

OrKoN commented Aug 16, 2023

also, npm run docs is needed since the API docs are changed

@mathiasbynens
Copy link
Member Author

Docs pushed!

@OrKoN
Copy link
Collaborator

OrKoN commented Aug 16, 2023

@mathiasbynens I have overlooked missing tests, let's add a test for the chrome-headless-shell browser-data and perhaps one test making sure it's actually installable?

@OrKoN
Copy link
Collaborator

OrKoN commented Aug 16, 2023

also, it looks like the Firefox version has gone outdated so we need to bump it in the test files.

@OrKoN OrKoN enabled auto-merge (squash) August 16, 2023 11:25
@OrKoN OrKoN merged commit 416843b into main Aug 16, 2023
21 checks passed
@OrKoN OrKoN deleted the chrome-headless-shell branch August 16, 2023 11:34
@release-please release-please bot mentioned this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants