refactor: align names #10903
Merged
refactor: align names #10903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrandolf
force-pushed
the
align-names-with-convention
branch
from
dba6568
to
29f9734
Compare
jrandolf
approved these changes
Sep 13, 2023
jrandolf
force-pushed
the
align-names-with-convention
branch
from
29f9734
to
11d4996
Compare
swissspidy
added a commit
to swissspidy/jest-puppeteer
that referenced
this pull request
Sep 29, 2023
Puppeteer recently changed the naming of their classes in puppeteer/puppeteer#10903, which caused the case-sensitive class name checks in `expect-puppeteer` to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convention for abbreviation is to be lower case if there. First letter capitalization follow other conventions.
Internal only change, no user facing changes.