[WIP] Chrome's error line reporting is off-by-one in Chrome? #10921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This broke between Puppeteer 9 and 21.
jrandolf
force-pushed
the
pageerror-line
branch
from
c718a1f
to
e7364de
Compare
|
@Krinkle could you please report an issue with a minimal reproducible example? |
OrKoN
reviewed
Sep 18, 2023
| @@ -1369,6 +1369,7 @@ describe('Page', function () { | |||
| page.goto(server.PREFIX + '/error.html'), | |||
| ]); | |||
| expect(error.message).toContain('Fancy'); | |||
| expect(error.stack).toContain('error.html:130'); | |||
There was a problem hiding this comment.
I guess this is meant to be 13?
|
ignore my previous comment, I am able to reproduce. |
|
Closing in favor of #10926. |
Krinkle
added a commit
to qunitjs/qunit
that referenced
this pull request
Sep 23, 2023
Fixed offset bug upstream. Ref puppeteer/puppeteer#10921 Ref puppeteer/puppeteer#10926
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered via https://github.com/qunitjs/qunit where we integrate QUnit with grunt-contrib-qunit and verify how an uncaught error is reported.
Ref gruntjs/grunt-contrib-qunit#204.
Ref qunitjs/qunit@cb67c39.
Examples:
is now wrongly reported as line 15.
This broke between Puppeteer 9 and 21. I know that's a big gap. I don't have something more precise at the moment, and with workstations changing to ARM, and Puppeteer only recently supporting it, it's not particularly easy to narrow down.