Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename mocha-runner #10984

Merged
merged 1 commit into from
Sep 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ module.exports = {
{
files: [
'packages/puppeteer-core/src/**/*.test.ts',
'tools/mochaRunner/src/test.ts',
'tools/mocha-runner/src/test.ts',
],
rules: {
// With the Node.js test runner, `describe` and `it` are technically
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/changed-packages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
- 'docker/**'
- 'test/**'
- 'test-d/**'
- 'tools/mochaRunner/**'
- 'tools/mocha-runner/**'
- '.mocharc.cjs'
- 'tools/doctest/**'
website:
Expand Down
6 changes: 3 additions & 3 deletions docs/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ Puppeteer uses a custom test runner on top of Mocha that consults the
[TestExpectations.json](https://github.com/puppeteer/puppeteer/blob/main/test/TestExpectations.json)
to see if a given test result is expected or not. See more info about the test
runner in
[`tools/mochaRunner`](https://github.com/puppeteer/puppeteer/tree/main/tools/mochaRunner).
[`tools/mocha-runner`](https://github.com/puppeteer/puppeteer/tree/main/tools/mocha-runner).

### Unit tests

Expand Down Expand Up @@ -155,7 +155,7 @@ The following is a description of the primary folders in Puppeteer:
- `test-d` contains type tests using
[`tsd`](https://github.com/SamVerschueren/tsd).
- `tools` contains miscellaneous scripts that are used in building and etc.
- `tools/mochaRunner` - contains the source code for our test runner.
- `tools/mocha-runner` - contains the source code for our test runner.

## API guidelines

Expand Down Expand Up @@ -248,7 +248,7 @@ for details.
If a test is expected to fail on certain configurations or became flaky, update
[TestExpectations.json](https://github.com/puppeteer/puppeteer/blob/main/test/TestExpectations.json)
to reflect that. See more info about TestExpectations.json in
[`tools/mochaRunner`](https://github.com/puppeteer/puppeteer/tree/main/tools/mochaRunner).
[`tools/mocha-runner`](https://github.com/puppeteer/puppeteer/tree/main/tools/mocha-runner).

## API Coverage

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
]
},
"test": {
"command": "cross-env PUPPETEER_DEFERRED_PROMISE_DEBUG_TIMEOUT=20000 node tools/mochaRunner/lib/main.js --min-tests 1003",
"command": "cross-env PUPPETEER_DEFERRED_PROMISE_DEBUG_TIMEOUT=20000 node tools/mocha-runner/lib/main.js --min-tests 1003",
"dependencies": [
"./test:build"
]
Expand Down
2 changes: 1 addition & 1 deletion test/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ The best place to look is an existing test to see how they use the helpers.

## Skipping tests in specific conditions

To skip tests edit the [TestExpectations](https://github.com/puppeteer/puppeteer/blob/main/test/TestExpectations.json) file. See [test runner documentation](https://github.com/puppeteer/puppeteer/tree/main/tools/mochaRunner) for more details.
To skip tests edit the [TestExpectations](https://github.com/puppeteer/puppeteer/blob/main/test/TestExpectations.json) file. See [test runner documentation](https://github.com/puppeteer/puppeteer/tree/main/tools/mocha-runner) for more details.

## Running tests

Expand Down
2 changes: 1 addition & 1 deletion test/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"../packages/testserver:build"
],
"files": [
"../tools/mochaRunner/**",
"../tools/mocha-runner/**",
"src/**"
],
"output": [
Expand Down
2 changes: 1 addition & 1 deletion test/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@
"rootDir": "src"
},
"include": ["src"],
"references": [{"path": "../tools/mochaRunner/tsconfig.json"}]
"references": [{"path": "../tools/mocha-runner/tsconfig.json"}]
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ It uses `/test/TestSuites.json` and `/test/TestExpectations.json` files to run m
## Running tests for Mocha Runner itself.

```bash
npm run build && npx c8 node tools/mochaRunner/lib/test.js
npm run build && npx c8 node tools/mocha-runner/lib/test.js
```

## Running tests using Mocha Runner
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export interface MochaResults {
pending: MochaTestResult[];
passes: MochaTestResult[];
failures: MochaTestResult[];
// Added by mochaRunner.
// Added by mocha-runner.
updates?: RecommendedExpectation[];
parameters?: string[];
platform?: string;
Expand Down
File renamed without changes.
File renamed without changes.