Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test to make sure clipping is correct on retina displays #1111

Merged
merged 1 commit into from Oct 20, 2017
Merged

test: add test to make sure clipping is correct on retina displays #1111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Binary file added test/golden/screenshot-clip-odd-size.png
View file
Open in desktop
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
13 changes: 13 additions & 0 deletions test/test.js
View file
Open in desktop
Expand Up @@ -2531,6 +2531,19 @@ describe('Page', function() {
const screenshot = await page.screenshot({omitBackground: true});
expect(screenshot).toBeGolden('transparent.png');
}));
// Doesn't work on retina displays.
// @see https://github.com/GoogleChrome/puppeteer/issues/733
xit('should work with odd clip size on Retina displays', SX(async function() {
const screenshot = await page.screenshot({
clip: {
x: 0,
y: 0,
width: 11,
height: 11,
}
});
expect(screenshot).toBeGolden('screenshot-clip-odd-size.png');
}));
});

describe('Page.select', function() {
Expand Down