Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not pass --{enable,disable}-features twice when user-provided #11230

Merged
merged 3 commits into from
Oct 23, 2023
Merged

fix: do not pass --{enable,disable}-features twice when user-provided #11230

merged 3 commits into from
Oct 23, 2023

Commits on Oct 23, 2023

  1. fix: do not pass --{enable,disable}-features twice when user-provided 

    Currently, whenever the user provides:

    args: '--disable-features=TestDisableFeatures'

The --disable-features flag appears twice in chrome arguments.

Make it appear only once, by merging them.

Ditto for --enable-features.

Bug: #11208
    @thiagowfx
    thiagowfx committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    2aea381 View commit details
    Browse the repository at this point in the history

  2. chore: refactoring

    @thiagowfx
    thiagowfx committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    a76c1d2 View commit details
    Browse the repository at this point in the history

  3. chore: regexp -> string

    @thiagowfx
    thiagowfx committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    a3d6dbb View commit details
    Browse the repository at this point in the history