refactor: move console event handling #12407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/move-console-event
branch
3 times, most recently
from
9b6d95b
to
68b9d2a
Compare
OrKoN
force-pushed
the
orkon/move-console-event
branch
from
68b9d2a
to
cd4a839
Compare
Lightning00Blade
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The console events would propagate as following: ExecutionContext -> IsolatedWorld -> Frame -> FrameManager -> Page or ExecutionContext -> IsolatedWorld -> WebWorker instead of trying to locate the execution context for an event determined at the page level.
Also, it adds explicit disposal of the instances when the client is gone.