fix: don't show max listeners warning when running tests in parallel #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelEinbinder
force-pushed
the
max_listeners_parallel
branch
from
a2ecc2c
to
0b14225
Compare
aslushnikov
reviewed
Jan 4, 2018
| @@ -60,8 +60,9 @@ if (process.env.PPTR_PARALLEL_TESTS) | |||
| const parallelArgIndex = process.argv.indexOf('-j'); | |||
| if (parallelArgIndex !== -1) | |||
| parallel = parseInt(process.argv[parallelArgIndex + 1], 10); | |||
| require('events').defaultMaxListeners *= parallel; | |||
There was a problem hiding this comment.
this will kill certain tests check for the warning, but i guess that's not a big deal for the parallel mode
aslushnikov
approved these changes
Jan 4, 2018
igorshapiro
pushed a commit
to WiserSolutions/puppeteer
that referenced
this pull request
Jan 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.