New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: flexible chromium revisions #2246
Conversation
Often we want to test changes on new chromium versions. At the moment we would have to switch from the default downloader to specifying our own executable and downloading that etc. Exposing this to an environment variable would make it easy to test against different chromium versions in CI environments.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
CLA is signed under Social Significance LTD |
@@ -30,7 +30,7 @@ const downloadHost = process.env.PUPPETEER_DOWNLOAD_HOST || process.env.npm_conf | |||
const puppeteer = require('./index'); | |||
const browserFetcher = puppeteer.createBrowserFetcher({ host: downloadHost }); | |||
|
|||
const revision = require('./package.json').puppeteer.chromium_revision; | |||
const revision = process.env.PUPPETEER_CHROMIUM_REVISION || require('./package.json').puppeteer.chromium_revision; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, we do have a BrowserFetcher
API that serves this purpose:
https://github.com/GoogleChrome/puppeteer/blob/master/docs/api.md#class-browserfetcher
But this one liner is a nicer than writing some code. @aslushnikov wdyt?
We'd need to also document this env var in https://github.com/GoogleChrome/puppeteer/blob/master/docs/api.md#environment-variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added the documentation as well FYI
CLAs look good, thanks! |
Often we want to test changes on new chromium versions. At the moment we would have to switch from the default downloader to specifying our own executable and downloading that etc.
Exposing this to an environment variable would make it easy to test against different chromium versions in CI environments.