Health: break page.spec.js to smaller files #2257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanivefraim
force-pushed
the
health-test
branch
from
65b6349
to
90b1ecc
Compare
aslushnikov
approved these changes
Mar 28, 2018
test/target.spec.js
Outdated
| @@ -0,0 +1,134 @@ | |||
| /** | |||
| * Copyright 2017 Google Inc. All rights reserved. | |||
There was a problem hiding this comment.
here and in the other created files: 2018.
yanivefraim
force-pushed
the
health-test
branch
from
1c526dd
to
9e14dfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Break some large chunks into smaller files. This change will remove ~600 lines from
page.spec.js