feat(FrameManage): add title for WaitTask #2292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslushnikov
reviewed
Mar 30, 2018
| @@ -696,7 +696,8 @@ class Frame { | |||
| const waitForVisible = !!options.visible; | |||
| const waitForHidden = !!options.hidden; | |||
| const polling = waitForVisible || waitForHidden ? 'raf' : 'mutation'; | |||
| return this.waitForFunction(predicate, {timeout: options.timeout, polling}, selectorOrXPath, isXPath, waitForVisible, waitForHidden); | |||
| const timeout = helper.isNumber(options.timeout) ? options.timeout : 30000; | |||
There was a problem hiding this comment.
is this a drive-by? Looks like an unrelated bugfix.
There was a problem hiding this comment.
Actually it is related to this comment:
There was a problem hiding this comment.
Your comment link didn't work for me.
But if I understand correctly, the page.waitForSelector/page.waitForXPath don't currently have default timeout 30 seconds (despite documentation claiming so), and this change brings it back.
There was a problem hiding this comment.
sorry, created it from mobile (it is working on mobile... strange)
The comment was: #2084 (comment)
There was a problem hiding this comment.
ah I see now. Thank you for the explanation.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2037
(no answer from @felixfbecker regarding #2084. Created a new PR. Sorry for that...)