Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Connection): do not assert that methods always have callbacks. #2330

Merged
merged 1 commit into from
Apr 8, 2018
Merged

fix(Connection): do not assert that methods always have callbacks. #2330

merged 1 commit into from
Apr 8, 2018

Commits on Apr 8, 2018

  1. fix(Connection): do not assert that methods always have callbacks. 

    In certain cases, all callbacks could be rejected before we get a
response from transport. This is easily reproducible with `slowMo`
option.

Fixes puppeteer#563.
    @aslushnikov
    aslushnikov committed Apr 8, 2018
    Configuration menu
    Copy the full SHA
    397b934 View commit details
    Browse the repository at this point in the history