test: refactor utils.waitForEvents into utils.waitEvent #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies waiting for events in tests.
test/page.spec.js
Outdated
| @@ -380,7 +377,7 @@ module.exports.addTests = function({testRunner, expect, defaultBrowserOptions, p | |||
| describe('Page.Events.DOMContentLoaded', function() { | |||
| it('should fire when expected', async({page, server}) => { | |||
| page.goto('about:blank'); | |||
| await waitForEvents(page, 'domcontentloaded', 1); | |||
| await waitEvent(page, 'domcontentloaded', 1); | |||
| console.log(Promise.resolve('should not wait until resolved!')); | ||
| }), | ||
| // Wait for 5 events to hit - console.time is not reported | ||
| waitForEvents(page, 'console', 5) |
There was a problem hiding this comment.
This works because console logs wait for the ack in JavaScript?
There was a problem hiding this comment.
That's because protocol is serial: console.log's will be posted before the evaluation response.
JoelEinbinder
approved these changes
Apr 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies waiting for events in tests.