Fix doc on pdf method. Minor addition to PDF path option docs. #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is also the case for |
|
Nice! Can we have the same clarification for the |
|
Yup, just looked into that and saw it is optional there as well. Updating now. |
|
🎉 CI failure on last run was due to some HTTPS thing. No way that could be due to the documentation changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone asked me whether or not they could get the PDF data without writing to a file. When checking the source to see, I saw the docblock was incorrect. So fixed that. Then added a quick note in the API docs about the path to save being optional. This may help people understand they can simply get just the returned buffer data for the PDF if desired.