Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chromium): roll Chromium to r587164 #3153

Merged
merged 2 commits into from Aug 30, 2018

Conversation

aslushnikov
Copy link
Contributor

This roll includes:

The "revert" patch fixes headless functionality on windows.

References #846.
Fixes #3106.

This roll includes:
- https://crrev.com/584293 - DevTools: execute scripts in addScriptToEvaluateOnLoad in order
- https://crrev.com/585630 - DevTools: introduce Browser.grantPermissions
- https://crrev.com/587156 - Revert "[Base] Use background mode for ThreadPriority::BACKGROUND threads (behind feature) (reland)."

The "revert" patch fixes headless functionality on windows.

References puppeteer#846.
Fixes puppeteer#3106.
@aslushnikov aslushnikov merged commit df459ba into puppeteer:master Aug 30, 2018
@aslushnikov aslushnikov deleted the roll-r587164 branch January 22, 2019 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling a exposed function inside an evaluateOnNewDocument function does not work on Chrome 70
2 participants