feat(frame): introduce Frame.goto and Frame.waitForNavigation #3276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch introduces API to manage frame navigations. As a drive-by, the `response.frame()` method is added as a shortcut for `response.request().frame()`. Fixes puppeteer#2918.
docs/api.md
Outdated
|
|
||
| > **NOTE** `frame.goto` either throw or return a main resource response. The only exceptions are navigation to `about:blank` or navigation to the same URL with a different hash, which would succeed and return `null`. | ||
|
|
||
| > **NOTE** Headless mode doesn't match any nodest navigating to a PDF document. See the [upstream issue](https://bugs.chromium.org/p/chromium/issues/detail?id=761295). |
There was a problem hiding this comment.
Is nodest a typo or some term?
docs/api.md
Outdated
|
|
||
| > **NOTE** `frame.goto` either throw or return a main resource response. The only exceptions are navigation to `about:blank` or navigation to the same URL with a different hash, which would succeed and return `null`. | ||
|
|
||
| > **NOTE** Headless mode doesn't match any nodest navigating to a PDF document. See the [upstream issue](https://bugs.chromium.org/p/chromium/issues/detail?id=761295). |
lib/FrameManager.js
Outdated
| */ | ||
| _onFrameDetached(frame) { | ||
| if (this._frame === frame) { | ||
| this._terminationCallback.call(null, new Error('Navigating frame is detached')); |
| @@ -2499,6 +2526,29 @@ const selector = '.foo'; | |||
| await page.waitForFunction(selector => !!document.querySelector(selector), {}, selector); | |||
| ``` | |||
|
|
|||
| #### frame.waitForNavigation(options) | |||
There was a problem hiding this comment.
Can we mark the page methods as shortcuts?
JoelEinbinder
approved these changes
Sep 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces API to manage frame navigations.
As a drive-by, the
response.frame()method is added as a shortcutfor
response.request().frame().Fixes #2918.