Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(executioncontext): warn on nested js handle #3591

Merged
merged 6 commits into from
Jan 14, 2019
Merged

feat(executioncontext): warn on nested js handle #3591

merged 6 commits into from
Jan 14, 2019

Commits on Nov 22, 2018

  1. feat(ExecutionContext): warn on nested js handle 

    ExecutionContext.evaluateHandle accepts arguments that are either
serializable, or JSHandles. A potential confusion is that it *does not*
accept arguments that *contain* JSHandles.

This patch adds a log message warning when it encounters that situation.

Fixes puppeteer#3562
    @bgschiller
    bgschiller committed Nov 22, 2018
    Configuration menu
    Copy the full SHA
    d0fe9b8 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2018

  1. feat(ExecutionContext): warn about nested JSHandle 

    remove the code checking if args contain a nested JSHandle, and
instead simply suggest the possibility.
    @bgschiller
    bgschiller committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    778339d View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2018

  1. only warn on TypeError

    @bgschiller
    bgschiller committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    488eab3 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2018

  1. feat(ExecutionContext): warn on nested js handle 

    Test that the error thrown includes the altered message
    @bgschiller
    bgschiller committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    c30683a View commit details
    Browse the repository at this point in the history

  2. remove trailing comma for node6

    @bgschiller
    bgschiller committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    c6c4d9c View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2019

  1. nit: naming

    @aslushnikov
    aslushnikov committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    89da3ad View commit details
    Browse the repository at this point in the history