Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(troubleshooting.md): Update troubleshooting.md #3606

Merged
merged 2 commits into from Dec 5, 2018
Merged

docs(troubleshooting.md): Update troubleshooting.md #3606

merged 2 commits into from Dec 5, 2018

Conversation

thealphadollar
Copy link
Contributor

The proposal adds a drop-down list in a similar fashion as Dependencies list since it feels a little weird to have list for a continuing detail as I assume that all the three options belong to the same level of information.

The proposal adds a drop-down list in a similar fashion as Dependencies list since it feels a little weird to have list for a continuing detail as I assume that all the three options belong to the same level of information.
Resolve link appearance issues

Co-Authored-By: thealphadollar <shivam.cs.iit.kgp@gmail.com>
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@thealphadollar
Copy link
Contributor Author

@vsemozhetbyt Thank you for the review; the changes requested by you have been implemented.

@thealphadollar
Copy link
Contributor Author

@vsemozhetbyt Please add your consent :)

@vsemozhetbyt
Copy link
Contributor

I think the suggestion can be deemed as consent per se)

@thealphadollar
Copy link
Contributor Author

@vsemozhetbyt I meant please do the process asked by google bot so this PR can be unblocked.

@vsemozhetbyt
Copy link
Contributor

Sorry, I am not sure what are the formal steps for this. If the admins define them, I will conform.

@aslushnikov aslushnikov changed the title Update troubleshooting.md docs(troubleshooting.md): Update troubleshooting.md Dec 5, 2018
Copy link
Contributor

@aslushnikov aslushnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@aslushnikov aslushnikov merged commit 8613e87 into puppeteer:master Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants