Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(troubleshooting): Update docs about copying file for setuid sandbox #3608

Merged
merged 1 commit into from Dec 5, 2018
Merged

docs(troubleshooting): Update docs about copying file for setuid sandbox #3608

merged 1 commit into from Dec 5, 2018

Conversation

WillGibson
Copy link
Contributor

@WillGibson WillGibson commented Nov 29, 2018

Very small change in light of operational experience while getting it running on Centos in Jenkins pipeline.

Without the -p, the permissions set in the chmod before this command are not carried over chrome cannot start.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@WillGibson
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@JoelEinbinder
Copy link
Collaborator

Thanks for the PR! Can you add to the description about what this does/why it is needed?

@WillGibson
Copy link
Contributor Author

Of course, I was rushing yesterday to get out of work in time for yoga. Done.

@aslushnikov aslushnikov changed the title Update docs re copying file for setuid sandbox docs(troubleshooting): Update docs about copying file for setuid sandbox Dec 5, 2018
@aslushnikov aslushnikov merged commit 68afb3c into puppeteer:master Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants