Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: tone of logo surface from light source #369

Merged
merged 1 commit into from Aug 18, 2017
Merged

readme: tone of logo surface from light source #369

merged 1 commit into from Aug 18, 2017

Conversation

kensoh
Copy link
Contributor

@kensoh kensoh commented Aug 18, 2017

This is a minor cosmetic update on Puppeteer's logo. The rectangle surface at lower left corner seems to have the wrong shade, base on the scene's light source. Below are the original and the updated ones. Of course, if the designer intentionally wants to make the design asymmetric then this is irrelevant.

This is a minor cosmetic update on Puppeteer's logo. The rectangle surface at lower left corner seems to have the wrong shade, base on the scene's light source. Below are the original and the updated ones. Of course, if the designer intentionally wants to make the design asymmetric then this is irrelevant.
@kensoh kensoh changed the title #366 - tone of logo surface from light source readme: tone of logo surface from light source Aug 18, 2017
Copy link
Contributor

@ebidel ebidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proper light sources are key! Thanks for the update.

@ebidel ebidel merged commit 500b956 into puppeteer:master Aug 18, 2017
@paulirish
Copy link
Collaborator

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants