Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(troubleshooting.md): Update running on Alpine example #3708

Conversation

sergiitk
Copy link
Contributor

@sergiitk sergiitk commented Dec 26, 2018

Refreshes "Running on Alpine":

  • Use latest LTS Node 10 on alpine in the example
  • The newest Chromium package supported on Alpine @edge channel is now 71
  • Puppeteer corresponding to Chromium 71 is v1.9.0
  • harfbuzz is now required by dynamic linking, Ref hb_font_set_variations: symbol not found #3019

Makes Running on Alpine up to date:

- Chrome is now available in LTS Node 10
- Chrome version is updated to the latest alpine `@edge`, 71
- Corresponding Puppeteer is updated to v1.9.0
- `harfbuzz` is now required by dynamic linking
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@sergiitk
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@sergiitk
Copy link
Contributor Author

sergiitk commented Dec 26, 2018

Just for some context: I was setting up Puppeteer in Docker for my project and had to fix a couple of things in the example to make it work. Looks like other people (f.e. #3019) had to jump over the same hoops, so I've decided to capture the working setup in the example.

Copy link
Contributor

@aslushnikov aslushnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@aslushnikov aslushnikov merged commit 82bef70 into puppeteer:master Jan 10, 2019
@sergiitk sergiitk deleted the docs/troubleshooting-update-alpine-example branch January 10, 2019 15:08
@sergiitk
Copy link
Contributor Author

Glad I could help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants