Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(page): page.waitForFunction should work with multiline strings #3727

Merged
merged 1 commit into from Jan 11, 2019
Merged

fix(page): page.waitForFunction should work with multiline strings #3727

merged 1 commit into from Jan 11, 2019

Conversation

fringd
Copy link
Contributor

@fringd fringd commented Jan 4, 2019

No description provided.

@fringd
Copy link
Contributor Author

fringd commented Jan 4, 2019

I'm not sure why the pr title lint is stuck :/

@aslushnikov aslushnikov changed the title Fixes #3723 fix(page): page.evaluate should work with multiline strings Jan 10, 2019
@aslushnikov
Copy link
Contributor

@fringd can you please add a test to //test/evaluation.spec.js?

aslushnikov
aslushnikov approved these changes Jan 11, 2019
View reviewed changes
Copy link
Contributor

@aslushnikov aslushnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this - I'll add a test in a follow-up

@aslushnikov aslushnikov changed the title fix(page): page.evaluate should work with multiline strings fix(page): page.waitForFunction should work with multiline strings Jan 11, 2019
@aslushnikov aslushnikov merged commit f731973 into puppeteer:master Jan 11, 2019
@fringd
Copy link
Contributor Author

fringd commented Jan 11, 2019

thanks! I'm super sick this week. thanks for writing the test ^_^

@aslushnikov
Copy link
Contributor

@fringd get well soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslushnikov aslushnikov aslushnikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fringd @aslushnikov