Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add test for waitForFunction with cross-process navigation #3826

Merged
merged 1 commit into from Jan 22, 2019
Merged

test: Add test for waitForFunction with cross-process navigation #3826

merged 1 commit into from Jan 22, 2019

Conversation

LinusU
Copy link
Contributor

@LinusU LinusU commented Jan 22, 2019

Added a test case for running waitForFunction during navigations. There is a similar test case for waitForSelector, but I didn't see any for waitForFunction that also has goto in it.

@aslushnikov aslushnikov merged commit 9fb89e1 into puppeteer:master Jan 22, 2019
@LinusU LinusU deleted the test-waitForFunction-navigation branch January 22, 2019 23:51
@LinusU
Copy link
Contributor Author

LinusU commented Jan 22, 2019

Thanks for the quick pull ❤️

@aslushnikov
Copy link
Contributor

Thanks for helping!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslushnikov aslushnikov aslushnikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LinusU @aslushnikov