chore(test): prepare tests to be run with Puppeteer-Firefox #3833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch aligns Puppeteer testing infrastructure with the approach we use in Puppeteer-Firefox. This patch: - makes all tests accept Puppeteer object as a function argument rather than require it statically. This way we can pass either Puppeteer or Puppeteer-Firefox to drive tests. - renames the `puppeteer.spec.js` into `launcher.spec.js`. The `puppeteer.spec.js` is now the entry point for all cross-browsers tests.
JoelEinbinder
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch aligns Puppeteer testing infrastructure with the approach
we use in Puppeteer-Firefox.
This patch:
rather than require it statically. This way we can pass either
Puppeteer or Puppeteer-Firefox to drive tests.
puppeteer.spec.jsintolauncher.spec.js. Thepuppeteer.spec.jsis now the entry point for all cross-browserstests.