Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: introduce //lib/api.js #3835

Merged
merged 3 commits into from
Jan 26, 2019

Commits on Jan 24, 2019

  1. chore: introduce //lib/api.js

    Introduce `//lib/api.js` that declares a list of publicly exposed
    classes.
    
    The `//lib/api.js` list superceedes dynamic `helper.tracePublicAPI()` calls
    and is used in the following places:
    - [ASYNC STACKS]: generate "async stacks" for publicy exposed API in `//index.js`
    - [COVERAGE]: move coverage support from `//lib/helper` to `//test/utils`
    - [DOCLINT]: get rid of 'exluded classes' hardcoded list
    
    This will help us to re-use our coverage and doclint infrastructure
    for Puppeteer-Firefox.
    
    Drive-By: it turns out we didn't run coverage for `SecurityDetails`
    class, so we lack coverage for a few methods there. These are excluded
    for now, sanity tests will be added in a follow-up.
    aslushnikov committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    abcd813 View commit details
    Browse the repository at this point in the history
  2. fix doclint tests

    aslushnikov committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    8b6e3e6 View commit details
    Browse the repository at this point in the history
  3. fix puppeteer-web

    aslushnikov committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    90e2d98 View commit details
    Browse the repository at this point in the history