Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(page): teach waitForSelector to return null #3846

Merged
merged 2 commits into from Jan 28, 2019
Merged

fix(page): teach waitForSelector to return null #3846

merged 2 commits into from Jan 28, 2019

Conversation

aslushnikov
Copy link
Contributor

page.waitForSelector should return null if waiting for hidden: true and there's no matching node in DOM.

Before this patch, page.waitForSelector would return some JSHandle
pointing to boolean value.

@aslushnikov
fix(page): teach waitForSelector to return null
a762fbf 
`page.waitForSelector` should return `null` if waiting for `hidden:
true` and there's no matching node in DOM.

Before this patch, `page.waitForSelector` would return some JSHandle
pointing to boolean value.
@aslushnikov aslushnikov merged commit 2061dd4 into puppeteer:master Jan 28, 2019
@aslushnikov aslushnikov deleted the fix-wait-for-selector branch January 28, 2019 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelEinbinder JoelEinbinder JoelEinbinder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aslushnikov @JoelEinbinder