feat(page): introduce page.setDefaultTimeout #3854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslushnikov
changed the title
Method `page.setDefaultTimeout` overrides default 30 seconds timeout for all `page.waitFor*` methods, including navigation and waiting for selectors. Fix puppeteer#3319.
aslushnikov
force-pushed
the
default-timeouts
branch
from
b31751b
to
e42d929
Compare
aslushnikov
commented
Jan 28, 2019
aslushnikov
commented
Jan 28, 2019
lib/FrameManager.js
Outdated
| @@ -59,7 +60,14 @@ class FrameManager extends EventEmitter { | |||
| * @param {number} timeout | |||
| */ | |||
| setDefaultNavigationTimeout(timeout) { | |||
There was a problem hiding this comment.
this shouldgo away
docs/api.md
Outdated
| @@ -1667,12 +1668,37 @@ await page.setCookie(cookieObject1, cookieObject2); | |||
| #### page.setDefaultNavigationTimeout(timeout) | |||
| - `timeout` <[number]> Maximum navigation time in milliseconds | |||
|
|
|||
| This setting will change the default maximum navigation time of 30 seconds for the following methods: | |||
| This setting will change the default maximum navigation time of 30 seconds for the following methods and related shortcuts: | |||
There was a problem hiding this comment.
This setting will change the default maximum navigation time of 30 seconds for the following methods and related shortcuts:
JoelEinbinder
approved these changes
Jan 29, 2019
docs/api.md
Outdated
| @@ -1396,7 +1397,7 @@ Shortcut for [page.mainFrame().focus(selector)](#framefocusselector). | |||
|
|
|||
| #### page.goBack([options]) | |||
| - `options` <[Object]> Navigation parameters which might have the following properties: | |||
| - `timeout` <[number]> Maximum navigation time in milliseconds, defaults to 30 seconds, pass `0` to disable timeout. The default value can be changed by using the [page.setDefaultNavigationTimeout(timeout)](#pagesetdefaultnavigationtimeouttimeout) method. | |||
| - `timeout` <[number]> Maximum navigation time in milliseconds, defaults to 30 seconds, pass `0` to disable timeout. The default value can be changed by using the [page.setDefaultNavigationTimeout(timeout)](#pagesetdefaultnavigationtimeouttimeout) or [page.setDefaultTimeout(timeout)](#pagesetdefaulttimeouttimeout) method. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method
page.setDefaultTimeoutoverrides default 30 seconds timeoutfor all
page.waitFor*methods, including navigation and waitingfor selectors.
Drive-by: teach
page.setContentrespectpage.setDefaultNavigationTimeout.Fix #3319.