fix(page): execute frame.waitFor{Selector,XPath} in secondary world #3856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch starts executing frame.waitForSelector and frame.waitForXPath in secondary world. As a result, websites that mutate page global context (e.g. removing global MutationObserver) don't break Puppeteer's behavior. Fixes puppeteer#609
JoelEinbinder
approved these changes
Jan 28, 2019
| * @return {Promise<Puppeteer.ElementHandle>} | ||
| */ | ||
| async _adoptElementHandle(elementHandle) { | ||
| assert(elementHandle.executionContext() !== this, 'Cannot adopt handle that already belongs to this execution context'); |
There was a problem hiding this comment.
Fine for now. But in the case of a future public version we should probably return elementHandle here instead of asserting.
There was a problem hiding this comment.
Public API will be either on DOMWorld or on ElementHandle, so we'll have an opportunity to think about it
| objectId: elementHandle._remoteObject.objectId, | ||
| }); | ||
| const {object} = await this._client.send('DOM.resolveNode', { | ||
| backendNodeId: nodeInfo.node.backendNodeId, |
There was a problem hiding this comment.
how does this work without taking a worldName?
There was a problem hiding this comment.
Follow-up: #3857
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch starts executing frame.waitForSelector and frame.waitForXPath
in secondary world. As a result, websites that mutate page global
context (e.g. removing global MutationObserver) don't break Puppeteer's
behavior.
Fixes #609