Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Respect the loglevel for logging #4014

Merged
merged 2 commits into from Mar 19, 2019
Merged

Conversation

stphnrdmr
Copy link
Contributor

@stphnrdmr stphnrdmr commented Feb 14, 2019

This adds support for disabling console.log when the loglevel asks for it.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@stphnrdmr
Copy link
Contributor Author

I think it could be argued that disabling this during CI is not universally loved. Respecting the log level seems like a good idea to me.

@googlebot
Copy link

CLAs look good, thanks!

@stphnrdmr stphnrdmr changed the title Respect the loglevel for logging fix: Respect the loglevel for logging Feb 14, 2019
install.js Outdated Show resolved Hide resolved
This adds support for disabling console.log on CI and when
the loglevel asks for it.
@stphnrdmr
Copy link
Contributor Author

@JoelEinbinder Do you agree with the latest changes? I don't know why CI is failing right now.

install.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants