fix(page): intersect content quads with viewport #4277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In certain cases inline element children might be positioned outside of viewport. In this case, we should intersect all content quads with viewport before we pick one to click into. Fixes puppeteer#4274.
JoelEinbinder
approved these changes
Apr 12, 2019
| */ | ||
| _intersectQuadWithViewport(quad, width, height) { | ||
| return quad.map(point => ({ | ||
| x: Math.min(Math.max(point.x, 0), width), |
There was a problem hiding this comment.
Nobody has added clamp to JavaScript yet? There’s probably an npm package for it :)
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain cases inline element children might be positioned
outside of viewport.
In this case, we should intersect all content quads with viewport
before we pick one to click into.
Fixes #4274.